Re: [PATCH v11 08/37] dt-bindings: pinctrl: airoha: an7583: allow configuration of non-gpio default pins as gpio and pwm

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The added `gpio-ranges` property in the DT example references a non-existent `pinctrl` label, causing `make dt_binding_check` to fail.
--

--- Patch [8]: [PATCH v11 08/37] dt-bindings: pinctrl: airoha: an7583: allow configuration of non-gpio default pins as gpio and pwm ---
commit fe2117a8a4dbc031149ba94f4003a2a7c07323ab
Author: Mikhail Kshevetskiy <[email protected]>

dt-bindings: pinctrl: airoha: an7583: allow configuration of non-gpio default pins as gpio and pwm

Some AN7583 pins have non-gpio default settings. This patch provides a way
to configure such pins as GPIO or PWM. Also add gpio-range property in the
dts example.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> index f52802a3ad79d..3e680c997fe26 100644
> --- a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
[ ... ]
> @@ -337,6 +347,8 @@ examples:
>        interrupt-controller;
>        #interrupt-cells = <2>;
>  
> +      gpio-ranges = <&pinctrl 0 2 53>;
> +
[Severity: Low]
Does this phandle reference cause dtc to fail during make dt_binding_check?

Looking at the examples section, the root node doesn't appear to have a label
defined for it. Without changing the definition from pinctrl { to
pinctrl: pinctrl {, the &pinctrl reference in gpio-ranges won't be resolved.

>        pcie1-rst-pins {
>          conf {
>            pins = "pcie_reset1";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8