Re: [PATCH v11 29/37] dt-bindings: pinctrl: airoha: an7583: add missed features

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing driver implementation for newly bound pinctrl groups and functions (olt, pon_alt, npu_uart).
--

--- Patch [29]: [PATCH v11 29/37] dt-bindings: pinctrl: airoha: an7583: add missed features ---
commit 0673f3e27d073f9daecb09cc39535f93b1b052ef
Author: Mikhail Kshevetskiy <[email protected]>

dt-bindings: pinctrl: airoha: an7583: add missed features

This commit adds missing pin-group and pin-function features to the
airoha,an7583-pinctrl device tree binding. Specifically, it adds support
for npu_uart, pon_alt, and olt pin muxing.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> index 24f1ac60eea84..aad2e9880ec6c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml

[ ... ]

> @@ -81,7 +81,15 @@ patternProperties:
>              then:
>                properties:
>                  groups:
> -                  enum: [pon]
> +                  enum: [pon, pon_alt]
> +          - if:
> +              properties:
> +                function:
> +                  const: olt
> +            then:
> +              properties:
> +                groups:
> +                  enum: [olt]

[Severity: Medium]
Will this require a corresponding update to the driver? The driver at
drivers/pinctrl/airoha/pinctrl-an7583.c does not appear to implement the
olt and pon_alt pin definitions, group definitions, or function mappings.

If a device tree node configures these new mux settings, could this cause a
regression where the pinctrl core fails to find the mapping in the driver's
function array and returns -EINVAL during mux setup?

>            - if:
>                properties:
>                  function:
> @@ -115,7 +123,7 @@ patternProperties:
>                  groups:
>                    items:
>                      enum: [uart2, uart2_cts_rts, hsuart, hsuart_cts_rts,
> -                           uart4, uart5]
> +                           uart4, uart5, npu_uart]

[Severity: Medium]
Is npu_uart fully implemented in the driver? Looking at pinctrl-an7583.c,
the npu_uart group is defined in the driver's pin array but appears to be
omitted from uart_groups and uart_func_group:

drivers/pinctrl/airoha/pinctrl-an7583.c:uart_func_group[] {
        .name = "uart2",
        ...
}

Without this mapping, could this cause a regression where the driver fails to
configure the uart function for the npu_uart group when
airoha_pinmux_set_mux() is called?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=29