Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Alphabetical sorting and schema structure violation in the compatible list.
--
--- Patch [1]: [PATCH v4 1/2] dt-bindings: serial: 8250: Add Airoha compatibles ---
commit 27d01f216d527b904216459304a02e2d8c5f87e2
Author: Benjamin Larsson <[email protected]>
dt-bindings: serial: 8250: Add Airoha compatibles
This commit adds compatibles for the Airoha SoC family's 16550-compatible
UART and High-Speed UART hardware. The hardware features a custom baud rate
settings register.
> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
> index bb7b9c87a8072..b6f7e093d8d7a 100644
> --- a/Documentation/devicetree/bindings/serial/8250.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> @@ -110,6 +110,11 @@ properties:
> - const: mrvl,pxa-uart
> - const: nuvoton,wpcm450-uart
> - const: nuvoton,npcm750-uart
> + - const: airoha,en7523-uart
> + - items:
> + - const: airoha,an7581-uart
> + - const: airoha,en7523-uart
> + - const: airoha,an7581-hsuart
[Severity: Low]
This isn't a bug, but are the airoha entries inserted out of alphabetical
order here? The existing const compatibles appear to be grouped together
and sorted alphabetically by vendor prefix, meaning airoha should likely
appear earlier in the list.
Additionally, should the items block for the multi-string compatible be
moved? It seems to break the structural convention of the file by inserting
an items block into the middle of the standalone const block, whereas other
items blocks are typically grouped together after the const entries.
> - const: nvidia,tegra20-uart
> - const: nxp,lpc3220-uart
> - items:
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.