Re: [PATCH 1/3] dt-bindings: reset: Add Apple SoC CIO reset

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unit address and reg mismatch in the dt-schema example causes `dt_binding_check` to fail.
--

--- Patch [1]: [PATCH 1/3] dt-bindings: reset: Add Apple SoC CIO reset ---
commit 97bcf50ad89703c7219aea4998995a3a045920b5
Author: Sven Peter <[email protected]>

dt-bindings: reset: Add Apple SoC CIO reset

This commit introduces device tree bindings for the CIO (USB4/Thunderbolt)
reset controller on Apple Silicon SoCs. It defines both a standalone node
representation for t8103 and a syscon sub-node representation for t600x.

> diff --git a/Documentation/devicetree/bindings/reset/apple,t8103-cio-reset.yaml b/Documentation/devicetree/bindings/reset/apple,t8103-cio-reset.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/apple,t8103-cio-reset.yaml

[ ... ]

> +examples:
> +  - |

[ ... ]

> +  - |
> +    power-management@28e080000 {
> +        compatible = "apple,t6000-pmgr", "apple,pmgr", "syscon", "simple-mfd";
> +        reg = <0x8e080000 0x1c000>;

[Severity: Low]
Does this unit address mismatch the reg property base address? The node's
unit address is @28e080000, but the reg property uses 0x8e080000. This
typically causes make dt_binding_check to fail due to a unit_address_vs_reg
warning from dtc.

> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        reset-controller@1a034 {
> +            compatible = "apple,t6000-cio-reset";
> +            reg = <0x1a034 0x4>;
> +            #reset-cells = <1>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1