Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `if` condition matching `compatible` uses a scalar `const: ti,keystone-spi`, which is invalid for an array and will silently fail to match, bypassing the conditional `power-domains` requirement.
--
--- Patch [2]: [PATCH v3 2/2] dt-bindings: spi: ti,davinci-spi: convert to DT schema ---
commit a5efe9443825ce2f7c099e64bba8a83549fd7607
Author: Bhargav Joshi <[email protected]>
dt-bindings: spi: ti,davinci-spi: convert to DT schema
This commit converts the TI DaVinci/Keystone SPI controller binding from text
format to DT schema. It also creates a separate schema for peripheral
properties, adds missing dmas and dma-names properties, and introduces
constraints for the ti,spi-wdelay property.
> diff --git a/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml b/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml
> new file mode 100644
> index 0000000000000..5bf74f3ca588f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/ti,davinci-spi.yaml
[ ... ]
> +allOf:
> + - $ref: spi-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + const: ti,keystone-spi
[Severity: Medium]
Will this condition correctly match the compatible string? Since the
compatible property is represented as a JSON array during evaluation, using a
scalar const match will fail silently.
As a result, device trees missing the mandatory power-domains property for
Keystone 2 66AK2G SoCs will pass validation without errors. Should this be
updated to use contains: const: ti,keystone-spi instead?
> + then:
> + required:
> + - power-domains
> +
> +unevaluatedProperties: false
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.