Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added `out-band-wakeup` device tree property is not defined in any bindings and is not parsed by any kernel driver or core code.
--
--- Patch [2]: [PATCH 2/4] arm64: dts: ti: k3-am62a7-sk: add out-band-wakeup property to m_can devices ---
commit 19d8465485a156bad59ccde394dc04242bee6cd4
Author: Kendall Willis <[email protected]>
arm64: dts: ti: k3-am62a7-sk: add out-band-wakeup property to m_can devices
The m_can pins can be a wakeup source in the deepest low power states,
despite being in the MCU domain which is OFF during deeper low power
states. Add the out-band-wakeup property to allow the out_band_wakeup flag
to be enabled during suspend for m_can devices.
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 821a9705bb7d4..27ab51a6f261b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -906,6 +906,7 @@ AM62AX_IOPAD(0x008, PIN_INPUT, 0) /* (J24) OSPI0_DQS */
> };
>
> &mcu_mcan0 {
> + out-band-wakeup;
[Severity: Medium]
Is this new property being parsed by any kernel driver or core code?
Looking through the kernel, there doesn't appear to be any code that reads the
"out-band-wakeup" string from the device tree or calls
device_set_out_band_wakeup() based on it. Without corresponding C code to parse
this property, does this addition have any functional effect on the
out_band_wakeup flag during suspend?
> pinctrl-names = "default", "wakeup";
> pinctrl-0 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_default>;
> pinctrl-1 = <&mcu_mcan0_tx_pins_default>, <&mcu_mcan0_rx_pins_wakeup>;
> @@ -917,6 +918,7 @@ &mcu_mcan0 {
> };
>
> &mcu_mcan1 {
> + out-band-wakeup;
[Severity: Medium]
Same question here, does the kernel currently consume this property for
mcu_mcan1 to enable the wakeup functionality described in the commit message?
> pinctrl-names = "default", "wakeup";
> pinctrl-0 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_default>;
> pinctrl-1 = <&mcu_mcan1_tx_pins_default>, <&mcu_mcan1_rx_pins_wakeup>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.