Re: [PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices
| Newsgroups | org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The `out-band-wakeup` property is added to the device tree but is neither parsed by any kernel C code nor documented in device tree bindings, rendering it functionally inert. -- --- Patch [3]: [PATCH 3/4] arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices --- commit 4ca80a2e891d70e706f8bb44ea395ee00e41e9dc Author: Kendall Willis <[email protected]> arm64: dts: ti: k3-am62p5-sk: add out-band-wakeup property to m_can devices This commit adds the out-band-wakeup property to the mcu_mcan0 and mcu_mcan1 nodes in the k3-am62p5-sk device tree. The intent is to enable the out_band_wakeup flag during suspend so the devices can serve as wakeup sources from deep low-power states. > diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts > --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts > +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts [ ... ] > @@ -815,6 +815,7 @@ &epwm1 { > }; > > &mcu_mcan0 { > + out-band-wakeup; [Severity: Medium] Is this property parsed by any driver code in the kernel? The commit message indicates this allows the out_band_wakeup flag to be enabled during suspend, but there does not appear to be any C code that actually parses the out-band-wakeup property from the device tree to apply this flag. Without driver support to parse this, the property will remain inert. Does this rely on a separate driver patch that is missing from this series? Additionally, is this property documented in the device tree bindings? If not, it will trigger dtbs_check validation errors. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3