Re: [PATCH v4 18/18] PCI/P2PDMA: Log detailed ACS routing diagnostics
Logan Gunthorpe <[email protected]>
| Newsgroups | org.kernel.vger.linux-doc,dev.linux.lists.iommu,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-21 13:38, Leon Romanovsky wrote:
> + if (ret) {
> + pci_info(pdev,
> + "P2PDMA ACS debug: Egress Control Vector read at %#x failed: %#x\n",
> + offset, ret);
This patch seems to add a lot of printk()s with "debug" text. I'm
wondering if maybe they should all be pci_dbg() prints? People trying to
debug why they can't enable P2PDMA would want to enable them. Machines
that are just accidentally doing a P2PDMA transaction and are not
supported won't spew a lot more noise to dmesg.
In either case, I might suggest just dropping the "debug" prefix as I'm
not sure it adds extra value.
Logan