Re: [PATCH] EDAC/versalnet: Pass flags=0 to memory_failure() for UE errors
Borislav Petkov <[email protected]>
| Newsgroups | org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260701214001.GFakWJMcM3nZgQ1ddK@fat_crate.local> |
On Wed, Jul 01, 2026 at 03:20:31PM +0530, Shubhrajyoti Datta wrote: > The MF_ACTION_REQUIRED flag is intended for synchronous exceptions > where the consuming process must be killed. For EDAC-reported errors > discovered asynchronously via polling/interrupt, flags=0 is the > correct choice, matching how other EDAC drivers invoke > memory_failure(). > > Signed-off-by: Shubhrajyoti Datta <[email protected]> > --- > > drivers/edac/versalnet_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c > index 97ec05d68bbb..d1af5e175f7e 100644 > --- a/drivers/edac/versalnet_edac.c > +++ b/drivers/edac/versalnet_edac.c > @@ -464,7 +464,7 @@ static void handle_error(struct mc_priv *priv, struct ecc_status *stat, > pfn = PHYS_PFN(pa); > > if (IS_ENABLED(CONFIG_MEMORY_FAILURE)) { > - err = memory_failure(pfn, MF_ACTION_REQUIRED); > + err = memory_failure(pfn, 0); > if (err) > edac_dbg(2, "memory_failure() error: %d", err); > else > -- A bunch of preexisting issues: https://sashiko.dev/#/patchset/20260701095040.4139675-1-shubhrajyoti.datta%40amd.com They need to be addressed first along with everything that is waiting on the ML. Then new patches ontop. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette