Re: [PATCH v4] EDAC/altera: use ECC manager compatible to select A10/S10 IRQ layout

Dinh Nguyen <[email protected]>
Newsgroups org.kernel.vger.linux-edac,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
Hi Rounak,

On 6/27/26 01:17, Rounak Das wrote:
> The SDMMC ECC IRQ layout selection uses CONFIG_64BIT to distinguish
> between Arria10 and Stratix10 paths.
> 
> Detect the SoC once at probe via the device match table (.data),
> store it in struct altr_arria10_edac, and use it instead of CONFIG_64BIT.
> 
> This keeps the decision correct for every ECC child device
> (OCRAM, SD/MMC, etc.) and avoids any runtime compatible lookup.
> 
> Signed-off-by: Rounak Das <[email protected]>
> ---
> v4:
>   - Carry the A10/S10 distinction in the device match table .data and read
>     it with device_get_match_data(), instead of of_device_is_compatible()
>     at runtime (Dinh).
> 

I tested on both 32-bit and 64-bit platforms and it looks good. However, 
did you want to go ahead and removed the 2 remaining CONFIG_64BIT ifdefs?

DInh
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.