Re: [PATCH] staging: sm750fb: convert camelCase parameters to snake_case
Greg Kroah-Hartman <[email protected]> Tue, 7 Jul 2026 11:13:14 +0200
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2026070710-amusing-gecko-a39f@gregkh> |
On Sun, Jun 14, 2026 at 09:28:38PM -0400, Noah Adkins wrote: > Convert the camelCase parameters in the 2D acceleration helper > prototypes to snake_case to conform to the kernel coding style > and to make them consistent with the parameter names in the > corresponding implementations. But they don't seem to match up with what the .c file says, right? Why not? For example: > int sm750_hw_copyarea(struct lynx_accel *accel, > - unsigned int sBase, unsigned int sPitch, > + unsigned int source_base, unsigned int source_pitch, > unsigned int sx, unsigned int sy, > - unsigned int dBase, unsigned int dPitch, > + unsigned int d_base, unsigned int d_pitch, "d_base" is "dest_base" in the .c file. Same for some other variables. thanks, greg k-h