Re: [PATCH 2/2] staging: sm750fb: unindent defines left by conditional removal
Nils Lehnen <[email protected]> Sat, 18 Jul 2026 06:31:33 +0000
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Jul 18, 2026 at 08:20:36AM +0200, Greg Kroah-Hartman wrote: > No, this is not correct, the indentation gives you context of what is > happening. Right, the indented defines are the values of the field define right above them, and unindenting throws that context away. I'll drop this patch. A v2 of the series crossed with your review -- please disregard its patch 2/2 as well. A v3 with only the conditional removal follows. Sorry also for the subject-less 1/2 in this thread; that was a local send-email mishap on my side. Thanks for the review, Nils