Re: [PATCH v2 0/2] staging: sm750fb: remove dead VALIDATION_CHIP code
Greg Kroah-Hartman <[email protected]> Sat, 18 Jul 2026 08:31:00 +0200
| Newsgroups | org.kernel.vger.linux-fbdev,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2026071837-ferocity-sixtyfold-7a4e@gregkh> |
On Sat, Jul 18, 2026 at 06:20:56AM +0000, Nils Lehnen wrote: > VALIDATION_CHIP is defined nowhere in the tree, yet fourteen > preprocessor conditionals in the sm750fb DDK files still test it. > Patch 1 resolves all of them (dead branches dropped, always-true > branches kept), as the driver TODO asks under "remove unused code"; > patch 2 cleans up the indentation and blank lines the removal leaves > behind. > > Verification, both patches: the disassembly of all ten sm750fb object > files (objdump -d, x86, CONFIG_FB_SM750=m) is bit-identical across the > series. Compile-tested only; no SM750 hardware available. > > All English text in this series (cover letter, commit messages, code > comments) was translated from a German draft with the assistance of > Claude Fable 5. > > v2: resend of v1 -- patch 1/2 of v1 arrived with an empty subject due > to a local send mishap; no code changes. > v1: https://lore.kernel.org/r/[email protected] Please wait a day or so between new versions, gives people a chance to review what you sent and you to make changes based on it. thanks, greg k-h