Re: [PATCH] fpga: bridge: Use sysfs_emit() instead of sprintf()

Xu Yilun <[email protected]> Mon, 2 Mar 2026 11:39:25 +0800
Newsgroups org.kernel.vger.linux-fpga,org.kernel.vger.linux-kernel
Message-ID <aaUGbWGo/DuzvE69@yilunxu-OptiPlex-7050>
On Thu, Jan 22, 2026 at 06:03:59PM +0800, Xu Yilun wrote:
> On Fri, Jan 16, 2026 at 10:36:26PM -0600, Dinh Nguyen wrote:
> > According to Documentation/filesystems/sysfs.rst, show() functions
> > should use sysfs_emit() when formatting the value to be returned to user
> 
> The doc says "New implementations ... should only use ...". The existing
> code is OK, the patch is also OK, but sorry I expect we don't churn code
> just for doing it. We could also append these trivial changes along with
> patchsets that make real improvements.

I'm sorry. I changed my mind and would like to apply this patch. This
change solves the inconsistent usage of sprintf() & sysfs_emit() in the
same file.

Reviewed-by: Xu Yilun <[email protected]>

> 
> Thanks,
> Yilun
>