Re: FAILED: Patch "fpga: dfl: use subsys_initcall to allow built-in drivers to be added" failed to apply to 6.12-stable tree
Thadeu Lima de Souza Cascardo <[email protected]> Mon, 2 Mar 2026 11:31:52 -0300
| Newsgroups | org.kernel.vger.linux-fpga,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Feb 28, 2026 at 08:18:22PM -0500, Sasha Levin wrote: > The patch below does not apply to the 6.12-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to <[email protected]>. > > Thanks, > Sasha Hi, Sasha! I grabbed queue-6.12/fpga-dfl-use-subsys_initcall-to-allow-built-in-drive.patch from https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git, and applied it on top of v6.12.74 with git-am and it does apply just fine. Was this message triggered accidentally, given the patch is still on the queue? Or how should I verify that it applies (or doesn't)? Thanks. Cascardo. > > ------------------ original commit in Linus's tree ------------------ > > From 267f53140c9d0bf270bbe0148082e9b8e5011273 Mon Sep 17 00:00:00 2001 > From: Thadeu Lima de Souza Cascardo <[email protected]> > Date: Mon, 15 Dec 2025 16:05:50 -0300 > Subject: [PATCH] fpga: dfl: use subsys_initcall to allow built-in drivers to > be added > > The dfl code adds a bus. If it is built-in and there is a built-in driver > as well, the dfl module_init may be called after the driver module_init, > leading to a failure to register the driver as the bus has not been added > yet. > > Use subsys_initcall, which guarantees it will be called before the drivers > init code. > > Without the fix, we see failures like this: > > [ 0.479475] Driver 'intel-m10-bmc' was unable to register with bus_type 'dfl' because the bus was not initialized. > > Cc: [email protected] > Fixes: 9ba3a0aa09fe ("fpga: dfl: create a dfl bus type to support DFL devices") > Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]> > Link: https://lore.kernel.org/r/[email protected] > Reviewed-by: Xu Yilun <[email protected]> > Signed-off-by: Xu Yilun <[email protected]> > --- > drivers/fpga/dfl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index 7022657243c0a..449c3a082e232 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -2018,7 +2018,7 @@ static void __exit dfl_fpga_exit(void) > bus_unregister(&dfl_bus_type); > } > > -module_init(dfl_fpga_init); > +subsys_initcall(dfl_fpga_init); > module_exit(dfl_fpga_exit); > > MODULE_DESCRIPTION("FPGA Device Feature List (DFL) Support"); > -- > 2.51.0 > > > >