Re: [PATCH v2] pinctrl: microchip-sgpio: add missing select REGMAP_MMIO

Linus Walleij <[email protected]>
Newsgroups org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID <CAD++jLm8cqC2Y6nJLy4KULSbq8+p=+eTDH9Kz2dDSpfZH0Eb0w@mail.gmail.com> 
On Sun, Jul 19, 2026 at 11:45 AM Benjamin Boortz <[email protected]> wrote:

> The driver calls ocelot_regmap_from_resource() via <linux/mfd/ocelot.h>,
> which internally uses devm_regmap_init_mmio() and requires REGMAP_MMIO.
> The Kconfig entry does not select REGMAP_MMIO, causing a build failure
> when no other driver in the config happens to pull in REGMAP_MMIO:
>
>   include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'
>
> Found by randconfig testing on arm64; tinyconfig reproducer below.
>
> Fixes: 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")
> Cc: [email protected]
> Signed-off-by: Benjamin Boortz <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>

Patch applied for fixes.

Yours,
Linus Walleij
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.