Re: [PATCH] pinctrl: qcom: ipq9650: fix audio_sec_mclk_in1/out1 group pins
Linus Walleij <[email protected]>
| Newsgroups | org.kernel.vger.linux-gpio,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAD++jLns-5nxWjwa9LiDVbvNngQE+OYF05nD+wd7J1H3rfv9yg@mail.gmail.com> |
On Sat, Jul 18, 2026 at 2:22 AM Taceddin Sancak <[email protected]> wrote: > The audio_sec_mclk_in1 and audio_sec_mclk_out1 groups both list > "gpio37", but in the pingroup table those functions are muxed on > gpio39, while gpio37 provides the audio_sec_mclk_in0/out0 variants. > This makes both functions unusable: selecting them on gpio39 is > rejected by the pinmux core because the group is not listed for the > function, and selecting them on gpio37 trips the WARN_ON() in > msm_pinmux_set_mux() and fails with -EINVAL because that group > cannot mux them. > > Point both groups at gpio39, matching the pingroup table. This also > mirrors the primary audio MCLK pair, where the mclk0 and mclk1 > variants live on separate pins (gpio53 and gpio51 respectively). > > Fixes: 3c8e7ba0e399 ("pinctrl: qcom: Introduce IPQ9650 TLMM driver") > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Taceddin Sancak <[email protected]> This patch -> Bartosz Acked-by: Linus Walleij <[email protected]> Yours, Linus Walleij