Re: [PATCH] pinctrl: bm1880: add missing select GENERIC_PINCONF

Linus Walleij <[email protected]> Sat, 25 Jul 2026 11:33:56 +0200

Newsgroups	org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.stable
Message-ID	<CAD++jLmVvYFYF9dA5060oQEfeejvKukw3B5H0TkJ=A_qnnugZg@mail.gmail.com>

On Mon, Jul 20, 2026 at 7:57 PM Benjamin Boortz <[email protected]> wrote:

> drivers/pinctrl/pinctrl-bm1880.c initialises its pinconf_ops with
> .is_generic = true, but that field is only present when
> CONFIG_GENERIC_PINCONF is enabled (guarded by #ifdef in pinconf.h).
> The Kconfig entry for PINCTRL_BM1880 never selects GENERIC_PINCONF,
> so any config that enables CONFIG_PINCTRL_BM1880=y without
> CONFIG_GENERIC_PINCONF=y fails to compile:
>
>   drivers/pinctrl/pinctrl-bm1880.c:1288:10: error: 'const struct pinconf_ops' has no member named 'is_generic'
>
> Found by randconfig testing on arm64; tinyconfig reproducer below.
> Add the missing select to fix the build.
>
> Fixes: 49bd61ebce5f ("pinctrl: Add pinconf support for BM1880 SoC")
> Cc: [email protected]
> Signed-off-by: Benjamin Boortz <[email protected]>

Patch applied for fixes!

Yours,
Linus Walleij