Re: [PATCH 1/2] gpio: realtek-otto: use __raw_readl/writel in realtek_gpio_update_line_imr()

On Fri, Jul 10, 2026 at 8:35 PM Rustam Adilov <[email protected]> wrote:

> In preparation for upcoming changes to how bank reads and writes
> are defined in this driver, change the ioread32 and iowrite32 to
> their __raw variants. The realtek_gpio_update_line_imr() function
> is used by all devices regardless of GPIO_PORTS_REVERSED flag and
> thus this is the only place where there shouldn't be any byte
> swapping whether SWAP_IO_SPACE config is enabled or not and that
> is only possible with __raw_readl and __raw_writel.
>
> Signed-off-by: Rustam Adilov <[email protected]>

This makes perfect sense, since the ARM-based ixp4xx does the
exact same thing in gpio-ixp4xx.c for endianness-agnosticism.

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij