Re: [REGRESSION] Re: [PATCH v7 8/8] x86/module: enable ROX caches for module text on 64 bit
Peter Zijlstra <[email protected]>
| Newsgroups | org.kernel.vger.linux-hexagon,org.kernel.vger.bpf,org.kernel.vger.linux-alpha,org.kernel.vger.linux-arch,org.kernel.vger.linux-csky,org.kernel.vger.linux-kernel,org.kernel.vger.linux-m68k,org.kernel.vger.linux-mips,org.kernel.vger.linux-modules,org.kernel.vger.linux-openrisc,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Jan 12, 2025 at 08:07:55PM +0100, Borislav Petkov wrote: > On Sun, Jan 12, 2025 at 08:42:05PM +0200, Ville Syrjälä wrote: > > On Wed, Oct 23, 2024 at 07:27:11PM +0300, Mike Rapoport wrote: > > > From: "Mike Rapoport (Microsoft)" <[email protected]> > > > > > > Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module > > > text allocations on 64 bit. > > > > Hi, > > > > This breaks resume from hibernation on my Alderlake laptop. > > > > Fortunately this still reverts cleanly. > > Does that hunk in the mail here fix it? > > https://lore.kernel.org/all/[email protected]/ There's definiltely breakage with that module_writable_address() nonsense in alternative.c that will not be fixed by that patch. The very simplest thing at this point is to remove: select ARCH_HAS_EXECMEM_ROX if X86_64 and try again next cycle.