Re: [PATCH v2 09/13] arch, mm: set max_mapnr when allocating memory map for FLATMEM
Christophe Leroy <[email protected]>
| Newsgroups | org.kernel.vger.linux-hexagon,dev.linux.lists.loongarch,org.infradead.lists.linux-riscv,org.infradead.lists.linux-snps-arc,org.infradead.lists.linux-um,org.kernel.vger.linux-alpha,org.kernel.vger.linux-arch,org.kernel.vger.linux-csky,org.kernel.vger.linux-kernel,org.kernel.vger.linux-m68k,org.kernel.vger.linux-mips,org.kernel.vger.linux-openrisc,org.kernel.vger.linux-parisc,org.kernel.vger.linux-s390,org.kernel.vger.linux-sh,org.kernel.vger.sparclinux,org.kvack.linux-mm,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
Hi Mike, Le 14/03/2025 à 10:25, Christophe Leroy a écrit : > > > Le 13/03/2025 à 14:49, Mike Rapoport a écrit : >> From: "Mike Rapoport (Microsoft)" <[email protected]> >> >> max_mapnr is essentially the size of the memory map for systems that use >> FLATMEM. There is no reason to calculate it in each and every >> architecture >> when it's anyway calculated in alloc_node_mem_map(). >> >> Drop setting of max_mapnr from architecture code and set it once in >> alloc_node_mem_map(). > > As far as I can see alloc_node_mem_map() is called quite late. > > I fear that it will regress commit daa9ada2093e ("powerpc/mm: Fix boot > crash with FLATMEM") > > Can you check ? I see this patch is now merged into mainline (v6.15-rc1). Have you been able to check and/or analyse whether it doesn't regress the fix in commit daa9ada2093e ("powerpc/mm: Fix boot crash with FLATMEM") ? Thanks Christophe