Re: [PATCH v6 2/4] dt-bindings: hwmon: pmbus: add MPS MPQ8646

On 7/29/26 15:01, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The newly added compatible string 'mps,mpq8646' lacks driver support in the mpq8785 PMBus driver.
> --
> 
> --- Patch [2]: [PATCH v6 2/4] dt-bindings: hwmon: pmbus: add MPS MPQ8646 ---
> commit 341628a3dba9f658492690f20d45d96084eb12d5
> Author: Vincent Jardin <[email protected]>
> 
> dt-bindings: hwmon: pmbus: add MPS MPQ8646
> 
> This commit adds the mps,mpq8646 compatible string to the existing MPQ8785
> device tree schema. The MPQ8646 step-down converter shares the same
> constraints for the mps,vout-fb-divider-ratio-permille property as the
> mpq8785.
> 
>> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> index 90970a0433e95..d7a32fb3b7af6 100644
>> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> @@ -18,6 +18,7 @@ properties:
>>         - mps,mpm3695
>>         - mps,mpm3695-25
>>         - mps,mpm82504
>> +      - mps,mpq8646
> 
> [Severity: Medium]
> Should the corresponding driver (drivers/hwmon/pmbus/mpq8785.c) also be
> updated to match this new compatible string?
> 
> Because the DT schema specifies the compatible string as an enum rather than
> allowing a fallback (e.g. to "mps,mpq8785"), it appears the MPQ8646 device
> will fail to probe. The OF match table in mpq8785_of_match currently lacks
> an entry for this new hardware:
> 
> static const struct of_device_id __maybe_unused mpq8785_of_match[] = {
> 	{ .compatible = "mps,mpm3695", .data = (void *)mpm3695 },
> 	{ .compatible = "mps,mpm3695-25", .data = (void *)mpm3695_25 },
> 	{ .compatible = "mps,mpm82504", .data = (void *)mpm82504 },
> 	{ .compatible = "mps,mpq8785", .data = (void *)mpq8785 },
> 	{ }
> };
> 
> The I2C ID table in mpq8785_id is similarly missing an "mpq8646" entry.
> Without these additions, will a device instantiated via this new standalone
> compatible string be completely ignored by the driver?
> 
>>         - mps,mpq8785
> 

Sashiko for sure doesn't understand that the same bindings file is used for multiple
drivers. For DT maintainers - is there some common guidance for situations like this ?

Guenter