Re: [PATCH v6 3/4] hwmon: pmbus: add MPQ8646 driver

On 7/29/26 15:05, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing named initializers in `struct i2c_device_id` array.
> --
> 
> --- Patch [3]: [PATCH v6 3/4] hwmon: pmbus: add MPQ8646 driver ---
> commit 63fabec4213f8ada1bf01d09967620e66fc9f459
> Author: Vincent Jardin <[email protected]>
> 
> hwmon: pmbus: add MPQ8646 driver
> 
> This commit adds a new driver for the MPS MPQ8646 PMBus device. It provides
> basic PMBus telemetry, alarm acknowledgement, STATUS_WORD extended bit
> decoding, NVM-backed post-mortem data, and an in-driver alarm-poll fallback.
> 
>> diff --git a/drivers/hwmon/pmbus/mpq8646.c b/drivers/hwmon/pmbus/mpq8646.c
>> new file mode 100644
>> index 0000000000000..1fd41d89e5bef
>> --- /dev/null
>> +++ b/drivers/hwmon/pmbus/mpq8646.c
> [ ... ]
>> +static const struct i2c_device_id mpq8646_id[] = {
>> +	{ "mpq8646", 0 },
>> +	{ },
>> +};
> 
> [Severity: Low]
> This isn't a bug, but should this array use named initializers? The I2C
> subsystem guidelines specify that initialized arrays of type struct
> i2c_device_id must use named initializers, such as:
> 	{ .name = "mpq8646", .driver_data = 0 },
> 

Yes, this needs to be a named initializer.

Thanks,
Guenter