Re: [PATCH v3] ACPI: APD: Add clock frequency for HJMC01 I2C controller

Andy Shevchenko <[email protected]> Tue, 11 Aug 2026 09:54:33 +0300

Newsgroups	org.kernel.vger.linux-i2c,org.kernel.vger.linux-acpi
Organization	Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo
Message-ID	<[email protected]>

On Tue, Aug 11, 2026 at 02:22:34PM +0800, clarke.li wrote:
> On Thu, Aug 06, 2026 at 11:31:01PM +0300, Andy Shevchenko wrote:
> > On Wed, Jul 22, 2026 at 03:30:31PM +0800, clarke.li wrote:

...

> > > +	.fixed_clk_rate = 200000000,
> >
> > Can you at some point update these constants to use
> >
> > 	.fixed_clk_rate = 200 * HZ_PER_MHZ,
> >
> > and so on?
> 
> Thanks for the suggestion, I will use 200 * HZ_PER_MHZ in the
> next version.
> 
> By the way, do you also want me to convert the other
> fixed_clk_rate constants in acpi_apd.c to use HZ_PER_MHZ?
> If so, I can send it as a separate cleanup patch.

The idea is that you convert existing ones in a separate patch and then use a
new format for the new hw support.

-- 
With Best Regards,
Andy Shevchenko