Re: [PATCH v3] ACPI: APD: Add clock frequency for HJMC01 I2C controller

On Thu, Aug 06, 2026 at 11:31:01PM +0300, Andy Shevchenko wrote:

> On Wed, Jul 22, 2026 at 03:30:31PM +0800, clarke.li wrote:
>
> > I2C clock frequency for HJMC01 is 200MHz, define a new ACPI
> > HID for it.
>
> ...

> > +	.fixed_clk_rate = 200000000,
>
> Can you at some point update these constants to use
>
> 	.fixed_clk_rate = 200 * HZ_PER_MHZ,
>
> and so on?

Thanks for the suggestion, I will use 200 * HZ_PER_MHZ in the
next version.

By the way, do you also want me to convert the other
fixed_clk_rate constants in acpi_apd.c to use HZ_PER_MHZ?
If so, I can send it as a separate cleanup patch.

> ...
>
> >  	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
> >  	{ "LECA0002", APD_ADDR(leca_spi_desc) },
> >  	{ "LECA0003", APD_ADDR(leca_i2c_desc) },
> > +	{ "HJMC3001", APD_ADDR(hjmc_i2c_desc) },
> >  	{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
>
> Keep it sorted.

You are right, HJMC3001 should be placed before LECA0002
alphabetically. I will fix the order in the next version.

--
Thanks,
Hongnan Li