Re: [PATCH v3 2/5] ata: libata-scsi: refactor ata_scsi_report_supported_opcodes()
Damien Le Moal <[email protected]>
| Newsgroups | org.kernel.vger.linux-ide |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 7/3/26 15:44, Hannes Reinecke wrote:
>> + {
>> + .op = MAINTENANCE_IN, .cdb_len = 12,
>> + .sa_valid = true,
>> + .sa = MI_REPORT_SUPPORTED_OPERATION_CODES
>> + },
>> + { .op = SECURITY_PROTOCOL_OUT, .cdb_len = 12 },
>> +};
>> +
>
> What an unusual formatting. I would have gone for multi-line
> entries even for the simple ones to keep formatting the same
> for all entries.
The multi-line for everything made the array really big, and hard to read. After
trying different things, I settled on this.
--
Damien Le Moal
Western Digital Research