Re: [PATCH v3 2/5] ata: libata-scsi: refactor ata_scsi_report_supported_opcodes()
Hannes Reinecke <[email protected]>
| Newsgroups | org.kernel.vger.linux-ide |
|---|---|
| Message-ID | <[email protected]> |
On 7/3/26 9:05 AM, Damien Le Moal wrote:
> On 7/3/26 15:44, Hannes Reinecke wrote:
>>> + {
>>> + .op = MAINTENANCE_IN, .cdb_len = 12,
>>> + .sa_valid = true,
>>> + .sa = MI_REPORT_SUPPORTED_OPERATION_CODES
>>> + },
>>> + { .op = SECURITY_PROTOCOL_OUT, .cdb_len = 12 },
>>> +};
>>> +
>>
>> What an unusual formatting. I would have gone for multi-line
>> entries even for the simple ones to keep formatting the same
>> for all entries.
>
> The multi-line for everything made the array really big, and hard to read. After
> trying different things, I settled on this.
>
>
Fair enough.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
[email protected] +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich