Re: [PATCH] ata: pata_rb532_cf: use devm_platform_ioremap_resource()

On 7/14/26 08:21, Rosen Penev wrote:
> Replace the open-coded platform_get_resource() plus devm_ioremap()
> sequence with a single devm_platform_ioremap_resource() call, which folds
> the resource lookup and mapping into one step and returns an ERR_PTR on
> failure, checked with IS_ERR() and propagated via PTR_ERR(). Similar to
> platform_get_irq(), it can return -EPROBE_DEFER so move it early.
> 
> The pata-rb532-cf platform device (arch/mips/rb532/devices.c) provides a
> single IORESOURCE_MEM window at the DEV1BASE chip-select, distinct from
> the other RB532 chip-selects, so the region reservation now performed by
> devm_platform_ioremap_resource() introduces no conflict. The mapped size
> is unchanged. Drop the redundant error message, as
> devm_platform_ioremap_resource() already logs on failure.
> 
> Built for MIPS (rb532_defconfig) with LLVM=1;
> drivers/ata/pata_rb532_cf.o compiles cleanly.
> 
> Assisted-by: opencode:hy3-free
> Signed-off-by: Rosen Penev <[email protected]>

Applied to for-7.3. Thanks!

-- 
Damien Le Moal
Western Digital Research