Re: [PATCH v3 3/6] iio: adc: xilinx-xadc: Split driver into core and platform files

Uwe Kleine-König <[email protected]> Thu, 30 Jul 2026 21:52:24 +0200

Newsgroups	org.kernel.vger.linux-iio,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel
Message-ID	<amuqm5qdzXqKutPS@monoceros>

Hello,

On Wed, Jul 29, 2026 at 06:24:52PM +0530, Dileep Kumar Nagavarapu wrote:
> @@ -19,21 +19,13 @@
>  #include <linux/err.h>
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
> -#include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>

I wonder why so many people recently add <linux/mod_devicetable.h> in
their patches. Is there some tool that suggests that?

Anyhow: Please don't. <linux/platform_device.h> is already enough to get
of_device_id (which is the only *_device_id this driver is using unless
I missed something).

linux/mod_devicetable.h will hopefully go away soon, so each patch
adding an #include for it is annoying.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)