Re: [PATCH v2 2/3] iio: proximity: add driver for Sharp GP2AP070S proximity sensor

Uwe Kleine-König <[email protected]> Thu, 30 Jul 2026 21:54:23 +0200

Newsgroups	org.kernel.vger.linux-iio,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-samsung-soc
Message-ID	<amurhVbZi_y0N55n@monoceros>

Hello,

On Fri, Jul 31, 2026 at 01:01:30AM +0530, Kaustabh Chakraborty wrote:
> +#include <linux/i2c.h>
> [...]
> +#include <linux/mod_devicetable.h>

<linux/i2c.h> is enough to get the definitions for i2c_device_id and
of_device_id. Please rely on that and don't explicitly add an include
for <linux/mod_devicetable.h>. The latter is a dependency hell and is
going away soon.

Best regards
Uwe

signature.asc (application/pgp-signature, 488 B)