Re: [PATCH v3 5/6] iio: light: ltr501: Add ltr329 driver support

"Andy Shevchenko" <[email protected]> writes:

> On Tue, Aug 04, 2026 at 07:02:16PM +0200, Esben Haabendal wrote:
>> This adds support for the LTR-329ALS-01 chip, which is similar to
>> LTR-303ALS-01, except for interrupt, which LTR-329ALS-01 chip does not
>> have.
>
> ...
>
>>  	if (client->irq > 0) {
>> +		if (!ltr501_has_irq_support(data->chip_info)) {
>> +			dev_err(&client->dev, "chip does not support irq\n");
>> +			ret = -EINVAL;
>
> Can this be
>
> 			ret = dev_err_probe(-EINVAL);

Sure can, if that is the preferred style. But it will probably still be
two lines due to line width considerations.

And personally, as it would not take advantage of the -EPROBE_DEFER
logic of dev_err_probe(), I find the dev_err() style more clear.

>> +			goto powerdown_on_error;
>> +		}

/Esben