Re: [PATCH v1 4/4] iio: adc: pac1934: Unshadow error codes in ->store()

On Thu, 2026-08-13 at 09:16 +0200, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> kstrtox() may return different error codes.
> 
> Unshadow them in the ->store() callback to give better error report.
> 
> While at it, add missing kstrtox.h inclusion.
> 
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
>  drivers/iio/adc/pac1934.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
> index 23055405a6e0..2d934452eb11 100644
> --- a/drivers/iio/adc/pac1934.c
> +++ b/drivers/iio/adc/pac1934.c
> @@ -19,6 +19,7 @@
>  #include <linux/i2c.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
> +#include <linux/kstrtox.h>
>  #include <linux/unaligned.h>
> 
>  /*
> @@ -494,11 +495,13 @@ static ssize_t pac1934_shunt_value_store(struct
> device *dev,
>         struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>         struct pac1934_chip_info *info = iio_priv(indio_dev);
>         struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> -       int sh_val;
> +       unsigned int sh_val;
> +       int ret;
> 
> -       if (kstrtouint(buf, 10, &sh_val)) {
> +       ret = kstrtouint(buf, 10, &sh_val);
> +       if (ret) {
>                 dev_err(dev, "Shunt value is not valid\n");
> -               return -EINVAL;
> +               return ret;
>         }
> 
>         scoped_guard(mutex, &info->lock)
> --
> 2.50.1

Reviewed-by: Marius Cristea <[email protected]>