Re: [PATCH v7 0/8] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support

Jiri Kosina <[email protected]> Mon, 3 Aug 2026 21:32:35 +0200 (CEST)
Newsgroups org.kernel.vger.linux-input,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Mon, 3 Aug 2026, Sriman Achanta wrote:

> This series moves the SteelSeries Arctis headset support out of
> hid-steelseries.c into its own module, reworks it around a per-model
> device_info table, hardens the battery power-supply lifetime, adds an
> asynchronous status interface, and finally adds support for the Arctis
> Nova 5X and Nova 7 families. After the split, hid-steelseries.c is left
> handling the SRW-S1 racing wheel and the MSI RGB LED devices.
> 
> Changes since v6:
>  - Rebased onto hid.git#for-7.3/steelseries.
>    - The split now leaves the MSI RGB code in hid-steelseries.c
>      alongside SRW-S1, and strips only the headset members from
>      struct steelseries_device. The MSI RGB quirk bit is renumbered
>      to BIT(1) since the two Arctis bits are gone.
>    - The Arctis hardening that came with the MSI commit moves into
>      hid-steelseries-arctis.c with the rest of the headset code: the
>      hdev->rsize < 3 guard in steelseries_is_vendor_usage_page(), the
>      battery_registered store/load-acquire pair, the !sd checks, and
>      the hid_hw_stop() on the hid_hw_open() error path. The
>      steelseries_is_headset() dispatch is dropped, as the new module
>      only binds headsets. The battery_registered flag then goes away
>      in patch 3, where the device_info rework guards every
>      power_supply_changed() on sd->battery instead.
>    - The v6 patch "HID: steelseries: Inline and simplify SRWS1 wheel
>      driver" is dropped. Its premise was that hid-steelseries.c only
>      handles the SRW-S1 after the split, which is no longer true.
>  - No other changes. The resulting hid-steelseries-arctis.c is
>    byte-identical to v6.

Thanks a lot for such a brisk rebase. Now queued.

-- 
Jiri Kosina
SUSE Labs