Re: [PATCH v2 3/4] sysctl: Disallow part ial updates for erroneous sysctl vectors
Bradley Morgan <[email protected]>
| Newsgroups | org.kernel.vger.linux-kselftest,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 17 August 2026 14:44:29 BST, Bradley Morgan <[email protected]> wrote: >On 17 August 2026 14:43:44 BST, Joel Granados <[email protected]> >wrote: >>On Sat, Aug 15, 2026 at 05:05:26PM +0100, Bradley Morgan wrote: >>> commit_conv_vec() writes the elements one by one, so a reader can >>> still see a mix of old and new values while the loop runs. Same as >>> before this series, so no regression, but the changelog could say >>> this doesn't make the write atomic either. Otherwise someone later >>> will expect the vector to change all at once. >> >>Seems reasonable: here is what I added to the commit message: >> >> >>" >>... This (The staging vector) does **not** make the write atomic as a >>reader >>can still see a partially updated vector. >> > >Good enough. > Hmm. Removed a folk off CC: ** Address not found ** Your message wasn't delivered to [email protected] because the address couldn't be found, or is unable to receive mail. Learn more here: https://support.google.com/mail/?p=NoSuchUser The response was: The email account that you tried to reach does not exist. Please try double-checking the recipient's email address for typos or unnecessary spaces. For more information, go to https://support.google.com/mail/?p=NoSuchUser :( > >>... >>" >> >>Best >> >>Joel >> >>> >>> The copy is limited by table->maxlen and only vectors pay for it. >>> >>> Fine by me. >>> >>> Reviewed-by: Bradley Morgan <[email protected]> >>> Thanks! >> > >Thanks! Thanks!