Re: [PATCH v7 3/9] leds: st1202: fix pattern duration prescaler and pattern_clear skip marker
Manuel Fombuena <[email protected]>
| Newsgroups | org.kernel.vger.linux-leds,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <GV1PR08MB8497C5BEF8AC4F56BE6C076CC5F42@GV1PR08MB8497.eurprd08.prod.outlook.com> |
On Thu, 2 Jul 2026, [email protected] wrote: > Pre-existing issues: > - [High] The driver improperly maps the single global ST1202 hardware pattern sequencer to independent per-LED operations, causing destructive interference between channels. > - [High] `st1202_led_pattern_set` does not clear trailing unused pattern slots, potentially executing stale delay steps if not preceded by `pattern_clear`. All issues raised are pre-existing and outside the scope of this patch. They will be addressed in a follow-up submission. -- Manuel Fombuena