Re: [PATCH v7 4/9] leds: st1202: set all pattern PWM slots to full after clearing pattern

On Thu, 2 Jul 2026, [email protected] wrote:

> New issues:
> - [High] Trailing unused pattern slots retain 100% duty cycle configurations, causing unintended maximum brightness flashes during shorter sequences.
> 
> Pre-existing issues:
> - [Critical] The driver assigns a sleeping function to the non-blocking `brightness_set` callback, causing kernel panics in atomic contexts.
> - [High] Single-channel pattern operations uncontrollably zero out shared pattern durations, breaking active patterns on all other LEDs.
> - [High] Pattern brightness values are written to 12-bit registers without scaling, causing extremely dim LED patterns.
> - [High] The `brightness_set_blocking` callback fails to update the brightness level.

The comment about trailing slots retaining 100% duty cycle is a
consequence of the pre-existing issue where st1202_led_pattern_set()
does not zero trailing slots when len < ST1202_MAX_PATTERNS. The root
fix is outside the scope of this series and will be addressed in a
follow-up submission.

The remaining comments are pre-existing issues outside the scope of
this patch and will be addressed in a follow-up submission.

--
Manuel Fombuena