Re: [PATCH v7 5/9] leds: st1202: fix spurious pattern sequence start in setup
Manuel Fombuena <[email protected]>
| Newsgroups | org.kernel.vger.linux-leds,dev.linux.lists.sashiko-reviews |
|---|---|
| Message-ID | <GV1PR08MB8497E7329DDF76EF826320FFC5F42@GV1PR08MB8497.eurprd08.prod.outlook.com> |
On Thu, 2 Jul 2026, [email protected] wrote: > Pre-existing issues: > - [High] The driver assigns a sleeping I2C function to the non-blocking `brightness_set` callback, and the blocking callback ignores brightness scaling. > - [Medium] `st1202_led_pattern_set` fails to truncate patterns, leaving trailing sequence steps active. > - [Medium] Per-LED pattern configuration in `st1202_led_pattern_clear` destructively overwrites shared global sequencer registers, breaking patterns running on other channels. > - [Medium] The driver leaves the hardware powered on upon probe failure or device unbind. All issues raised are pre-existing and outside the scope of this patch. They will be addressed in a follow-up submission. -- Manuel Fombuena