[PATCH v3 4/4] leds: 88pm860x: Convert to dev_err_probe()
Arunachalam <[email protected]> Sat, 25 Jul 2026 13:43:49 +0530
| Newsgroups | org.kernel.vger.linux-leds,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Replace open-coded dev_err() + return patterns with dev_err_probe(), which also handles -EPROBE_DEFER correctly. Signed-off-by: Arunachalam <[email protected]> --- drivers/leds/leds-88pm860x.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c index ef5c6c466..65f2af134 100644 --- a/drivers/leds/leds-88pm860x.c +++ b/drivers/leds/leds-88pm860x.c @@ -152,16 +152,12 @@ static int pm860x_led_probe(struct platform_device *pdev) if (data == NULL) return -ENOMEM; res = platform_get_resource_byname(pdev, IORESOURCE_REG, "control"); - if (!res) { - dev_err(&pdev->dev, "No REG resource for control\n"); - return -ENXIO; - } + if (!res) + return dev_err_probe(&pdev->dev, -ENXIO, "No REG resource for control\n"); data->reg_control = res->start; res = platform_get_resource_byname(pdev, IORESOURCE_REG, "blink"); - if (!res) { - dev_err(&pdev->dev, "No REG resource for blink\n"); - return -ENXIO; - } + if (!res) + return dev_err_probe(&pdev->dev, -ENXIO, "No REG resource for blink\n"); data->reg_blink = res->start; memset(data->name, 0, MFD_NAME_SIZE); switch (pdev->id) { @@ -203,10 +199,8 @@ static int pm860x_led_probe(struct platform_device *pdev) mutex_init(&data->lock); ret = led_classdev_register(chip->dev, &data->cdev); - if (ret < 0) { - dev_err(&pdev->dev, "Failed to register LED: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "Failed to register LED\n"); pm860x_led_set(&data->cdev, 0); platform_set_drvdata(pdev, data); -- 2.39.5