Re: [PATCH v2 2/5] fbdev: Give atafb proper parent

Hi

Am 16.08.26 um 09:37 schrieb Michael Schmitz:
> From: Miro Kropacek <[email protected]>
>
> The atafb fb device registers no parent, causing a missing symlink
> (/sys/class/graphics/fb0/device). Xorg fbdevhw driver looks for that
> symlink when scanning for devices, so add a parent node for atafb.

Do you really have these devices to test with?

If so, could you also replace the hard coded fb_info with a call to 
framebuffer_alloc()?

>
> Signed-off-by: Miro Kropacek <[email protected]>
> Reviewed-by: Michael Schmitz <[email protected]>
> Signed-off-by: Michael Schmitz <[email protected]>
> Cc: <[email protected]>
> Link: https://lists.debian.org/debian-68k/2026/08/msg00000.html
> ---
>   drivers/video/fbdev/atafb.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c
> index b8ed1c537293..3d540803dc2b 100644
> --- a/drivers/video/fbdev/atafb.c
> +++ b/drivers/video/fbdev/atafb.c
> @@ -3101,6 +3101,11 @@ static int __init atafb_probe(struct platform_device *pdev)
>   #endif /* ATAFB_EXT */
>   
>   //	strcpy(fb_info.mode->name, "Atari Builtin ");
> +	/* Parent the fb device properly: without this fb0 registers as a
> +	 * virtual sysfs device with no /sys/class/graphics/fb0/device link,
> +	 * which makes Xorg's fbdevhw reject it ("No devices detected").
> +	 */
> +	fb_info.device = &pdev->dev;

Because this is supposed to happen in framebuffer_alloc() and keeping it 
there would be preferable.

Best regards
Thomas

>   	fb_info.fbops = &atafb_ops;
>   	// try to set default (detected; requested) var
>   	do_fb_set_var(&atafb_predefined[default_par - 1], 1);

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)