Re: [PATCH v3 2/2] console_codes.4: document more xterm codes
Alejandro Colomar <[email protected]> Wed, 8 Jul 2026 14:02:22 +0200
| Newsgroups | org.kernel.vger.linux-man |
|---|---|
| Message-ID | <ak47_pq0BTsoSw0P@devuan> |
Hi Jan, On 2026-07-08T13:58:04+0200, Jan Engelhardt wrote: > > On Wednesday 2026-07-08 13:17, Alejandro Colomar wrote: > > >> ESC ] 1 ; \f[I]txt\f[] ST Set icon name to \f[I]txt\f[]. > >> ESC ] 2 ; \f[I]txt\f[] ST Set window title to \f[I]txt\f[]. > >> -ESC ] 4 ; \f[I]num\f[] ; \f[I]txt\f[] ST Set ANSI color \f[I]num\f[] to \f[I]txt\f[]. > >> -ESC ] 10 ; \f[I]txt\f[] ST Set dynamic text color to \f[I]txt\f[]. > >> +ESC ] 4 ; \f[I]num\f[] ; \f[I]txt\f[] ST Set color \f[I]num\f[] (0-255) to \f[I]txt\f[]. > > > >This seems to reword the description of ESC]4;num;txt, which doesn't > >seem to match the commit message. Should this go into a separate > >commit? > > I had inspected the xterm source code to figure out what codes are available > and what they really do. This naturally led to rewording inaccurate > descriptions in console_codes. I do not think it is necessary to split this > into much more commits. I could might have written > > console_codes.4: document more xterm codes and fix some behavioral descriptions > > but that gets a little long for a summary line, wdyt? I prefer a couple of commits. One commit fixing existing descriptions and another one adding new ones. Two commits should be enough. That makes the diff nicer. Cheers, Alex > > -- <https://www.alejandro-colomar.es>
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmpOPEcACgkQ64mZXMKQ wqnG7w/9GEupR2SinKhUl/oFeKhDQJy3ojvXgmHyzoDtqicVGGeyQ9RhZ3OP5hLc 51oV+H5Jhfzzy4Ka/DVvI3YdOigv9/BsPd8/fVDGcj1j2ekVx0+ftQygz/wVnbkw usGomLWg4zuGTvh32QjrRL2FyNtyZu5N+dEVBCSsnQkuldOQulMNkJuoDyybRqDa 9PCV/Q0W67wzjE1xcy3VE6lhJGO67sRWCAfgbBwJDdZXFDqVZe2NDhdnrvgq17d5 VnQVGPMGqZN4cbjVJ/+16p930H7kvJrZpoB5cIqzvXFxnd8oPKGYStl/G0pZS7fr k+itWuoyNlkcGR4zhImkGsM85EReWpjUjkPvUyvs3URaqm4gLeIV/Zihyr4HRKg3 lHTYcRgQ3QzNn81lNArDNjwweXHGX/IZSF5NkNpzI5bk2TXLxLwZbL5SbBpiS+rz nPNjnki8UtAbC4JhIzhLHOp5vBvK/PmYPcPo3AtH/3RER4bcQE6B8CmhNYErhT2k H3lnX6G2BUxihY9xx72SPnaDa1kPjnk3sGgp69sHVIHNn873zTuem6Qoit/WWvpV 9unuqFXgYt0MntIm5Rlj43gPMqXyO76OU4CmxYyL2C/QTvNPDqwLjb1Wzo/acV76 5iOnWVEXj6ZqrUv0XmavolIRKVJgg40gmqW3VNXHwoukFPqwB7I= =V8aF -----END PGP SIGNATURE-----