Re: [PATCH 27/34] nilfs2: Convert nilfs_btnode_submit_block to bh_submit()

On Wed, May 27, 2026 at 2:52=E2=80=AFAM Viacheslav Dubeyko wrote:
>
> On Mon, 2026-05-25 at 18:19 +0100, Matthew Wilcox (Oracle) wrote:
> > Avoid an extra indirect function call by using bh_submit() instead of
> > submit_bh().
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> > Cc: [email protected]
> > ---
> >  fs/nilfs2/btnode.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/nilfs2/btnode.c b/fs/nilfs2/btnode.c
> > index 2e553d698d0f..0a4b61498eff 100644
> > --- a/fs/nilfs2/btnode.c
> > +++ b/fs/nilfs2/btnode.c
> > @@ -134,9 +134,8 @@ int nilfs_btnode_submit_block(struct address_space =
*btnc, __u64 blocknr,
> >       }
> >       set_buffer_mapped(bh);
> >       bh->b_blocknr =3D pblocknr; /* set block address for read */
> > -     bh->b_end_io =3D end_buffer_read_sync;
> >       get_bh(bh);
> > -     submit_bh(opf, bh);
> > +     bh_submit(bh, opf, bh_end_read);
> >       bh->b_blocknr =3D blocknr; /* set back to the given block address=
 */
> >       *submit_ptr =3D pblocknr;
> >       err =3D 0;
>
> Looks good.
>
> Reviewed-by: Viacheslav Dubeyko <[email protected]>
>
> Thanks,
> Slava.

Acked-by: Ryusuke Konishi <[email protected]>

Thanks,
Ryusuke Konishi