Re: [PATCH 28/34] nilfs2: Convert nilfs_gccache_submit_read_data to bh_submit()

On Wed, May 27, 2026 at 2:54=E2=80=AFAM Viacheslav Dubeyko wrote:
>
> On Mon, 2026-05-25 at 18:19 +0100, Matthew Wilcox (Oracle) wrote:
> > Avoid an extra indirect function call by using bh_submit() instead of
> > submit_bh().
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> > Cc: [email protected]
> > ---
> >  fs/nilfs2/gcinode.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/nilfs2/gcinode.c b/fs/nilfs2/gcinode.c
> > index 62d4c1b787e9..f979dc9d04b8 100644
> > --- a/fs/nilfs2/gcinode.c
> > +++ b/fs/nilfs2/gcinode.c
> > @@ -83,9 +83,8 @@ int nilfs_gccache_submit_read_data(struct inode *inod=
e, sector_t blkoff,
> >       if (!buffer_mapped(bh))
> >               set_buffer_mapped(bh);
> >       bh->b_blocknr =3D pbn;
> > -     bh->b_end_io =3D end_buffer_read_sync;
> >       get_bh(bh);
> > -     submit_bh(REQ_OP_READ, bh);
> > +     bh_submit(bh, REQ_OP_READ, bh_end_read);
> >       if (vbn)
> >               bh->b_blocknr =3D vbn;
> >   out:
>
> Looks good.
>
> Reviewed-by: Viacheslav Dubeyko <[email protected]>
>
> Thanks,
> Slava.

Acked-by: Ryusuke Konishi <[email protected]>

Thanks,
Ryusuke Konishi