Re: [PATCH 29/34] nilfs2: Convert nilfs_mdt_submit_block to bh_submit()

Ryusuke Konishi <[email protected]> Thu, 28 May 2026 02:46:15 +0900
Newsgroups org.kernel.vger.linux-nilfs,org.kernel.vger.linux-fsdevel
Message-ID <CAKFNMonfZ+VKyhKSWa6=0+hpKy+HtNmch2LV7KezhAgXAa2oDA@mail.gmail.com>
On Wed, May 27, 2026 at 2:53=E2=80=AFAM Viacheslav Dubeyko wrote:
>
> On Mon, 2026-05-25 at 18:19 +0100, Matthew Wilcox (Oracle) wrote:
> > Avoid an extra indirect function call by using bh_submit() instead of
> > submit_bh().
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
> > Cc: [email protected]
> > ---
> >  fs/nilfs2/mdt.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/nilfs2/mdt.c b/fs/nilfs2/mdt.c
> > index 09adb40c65e5..26043db677cd 100644
> > --- a/fs/nilfs2/mdt.c
> > +++ b/fs/nilfs2/mdt.c
> > @@ -148,9 +148,8 @@ nilfs_mdt_submit_block(struct inode *inode, unsigne=
d long blkoff, blk_opf_t opf,
> >       }
> >       map_bh(bh, inode->i_sb, (sector_t)blknum);
> >
> > -     bh->b_end_io =3D end_buffer_read_sync;
> >       get_bh(bh);
> > -     submit_bh(opf, bh);
> > +     bh_submit(bh, opf, bh_end_read);
> >       ret =3D 0;
> >
> >       trace_nilfs2_mdt_submit_block(inode, inode->i_ino, blkoff,
>
> Looks good.
>
> Reviewed-by: Viacheslav Dubeyko <[email protected]>
>
> Thanks,
> Slava.

Acked-by: Ryusuke Konishi <[email protected]>

Thanks,
Ryusuke Konishi