Re: [PATCH] ASoC: ti: omap-dmic: Fix IS_ERR() vs NULL check bug in omap_dmic_select_fclk()

On 5/14/2026 1:52 PM, Ingyu Jang wrote:
> clk_get_parent() returns NULL when the clock has no parent (or when the
> input clk is NULL); it never returns an ERR_PTR. The current IS_ERR(mux)
> check therefore never triggers - a NULL return falls through silently
> to clk_set_parent(NULL, parent_clk), which simply fails with -EINVAL.
> 
> Use a NULL check so the dedicated error path runs and the prior
> clk_get() reference is released via clk_put().
> 
> Signed-off-by: Ingyu Jang <[email protected]>
> ---
>   sound/soc/ti/omap-dmic.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/ti/omap-dmic.c b/sound/soc/ti/omap-dmic.c
> index fb92bb88eb5c2..f6c393c9489d6 100644
> --- a/sound/soc/ti/omap-dmic.c
> +++ b/sound/soc/ti/omap-dmic.c
> @@ -328,7 +328,7 @@ static int omap_dmic_select_fclk(struct omap_dmic *dmic, int clk_id,
>   	}
>   
>   	mux = clk_get_parent(dmic->fclk);
> -	if (IS_ERR(mux)) {
> +	if (!mux) {
>   		dev_err(dmic->dev, "can't get fck mux parent\n");
>   		clk_put(parent_clk);
>   		return -ENODEV;

Hi Ingyu,

looks good to me, thanks for the patch.

Acked-by: Sen Wang <[email protected]>

Best,
Sen Wang