Re: [PATCH] ASoC: ti: omap-mcbsp: Remove mixed goto/scoped cleanup handling
"Wang, Sen" <[email protected]>
| Newsgroups | org.kernel.vger.linux-omap,dev.linux.lists.asahi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
On 5/14/2026 6:06 AM, [email protected] wrote: > From: bui duc phuc <[email protected]> > > After converting to guard()/scoped_guard() helpers, > omap_mcbsp_request() still mixes scoped cleanup with > goto based error handling. > > Remove the remaining goto based cleanup paths for a more > consistent cleanup flow. > > Suggested-by: Mark Brown <[email protected]> > Signed-off-by: bui duc phuc <[email protected]> > --- > sound/soc/ti/omap-mcbsp.c | 46 +++++++++++++++++++-------------------- > 1 file changed, 22 insertions(+), 24 deletions(-) > Hi bui duc phuc, The logic looks good to me, thanks for your cleanup! Acked-by: Sen Wang <[email protected]> Best, Sen Wang