Re: [PATCH v1 0/3] gpio: Use named initializers for platform_device_id arrays
Bartosz Golaszewski <[email protected]>
| Newsgroups | org.kernel.vger.linux-omap,dev.linux.lists.chrome-platform,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 27 May 2026 16:57:26 +0200, Uwe Kleine-König (The Capable Hub) wrote:
> this series targets to use named initializers for platform_device_id
> arrays. In general these are better readable for humans and more robust
> to changes in the respective struct definition.
>
> This robustness is needed as I want to do
>
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -610,4 +610,7 @@ struct dmi_system_id {
> struct platform_device_id {
> char name[PLATFORM_NAME_SIZE];
> - kernel_ulong_t driver_data;
> + union {
> + kernel_ulong_t driver_data;
> + const void *driver_data_ptr;
> + };
> };
>
> [...]
I fixed your SoB as requested and fixed up patch 2/3 as one of the drivers it
touched no longer exists in my tree.
[1/3] gpio: cros-ec: Drop unused assignment of platform_device_id driver data
https://git.kernel.org/brgl/c/516e4d886941568174f46985fbb7c960c516ada9
[2/3] gpio: Use named initializers for platform_device_id arrays
https://git.kernel.org/brgl/c/2d43fb71f4ecbd10649a277e8790e7ca27acfdfe
[3/3] gpio: max77620: Unify usage of space and comma in platform_device_id array
https://git.kernel.org/brgl/c/a8754838f83a9905af516f38dd2633744a94f71a
Best regards,
--
Bartosz Golaszewski <[email protected]>