Re: [PATCH v1 0/3] gpio: Use named initializers for platform_device_id arrays
Uwe Kleine-König (The Capable Hub) <[email protected]>
| Newsgroups | org.kernel.vger.linux-omap,dev.linux.lists.chrome-platform,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pwm,org.kernel.vger.linux-renesas-soc |
|---|---|
| Message-ID | <ahgUGOsIxlFrf9mD@monoceros> |
Hello Bartosz,
On Thu, May 28, 2026 at 10:47:55AM +0200, Bartosz Golaszewski wrote:
> On Wed, 27 May 2026 16:57:26 +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > this series targets to use named initializers for platform_device_id
> > arrays. In general these are better readable for humans and more robust
> > to changes in the respective struct definition.
> >
> > This robustness is needed as I want to do
> >
> > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> > --- a/include/linux/mod_devicetable.h
> > +++ b/include/linux/mod_devicetable.h
> > @@ -610,4 +610,7 @@ struct dmi_system_id {
> > struct platform_device_id {
> > char name[PLATFORM_NAME_SIZE];
> > - kernel_ulong_t driver_data;
> > + union {
> > + kernel_ulong_t driver_data;
> > + const void *driver_data_ptr;
> > + };
> > };
> >
> > [...]
>
> I fixed your SoB as requested and fixed up patch 2/3 as one of the drivers it
> touched no longer exists in my tree.
Right, I noticed that conflict when rebasing my stack to next-20260527
and assumed you'd cope for that.
Thanks!
Uwe
signature.asc
(application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoYFG4ACgkQj4D7WH0S /k5FBQf+Ibzmukpa6UhZfcZUhGe0XaS6TZpmFiyy9QMJVqt3bKHdEafowQgl32yf 5w0pLkWFfORjHv+FEfH+wollsB7//hBHnEOT2nlVo2tI9s4lxfmJlJBAQYUSOPIs vKiKxxRT5p4uRCRhV1JWg2TBVimsUw9GG2tTXHK9jOMI2SU3iYsKoSbmQLN9Rctw k7N3zinvmqjGvYrYWYSdwN8ocBYa0b4JZGH2N3QabvS92i9doS2RMU46QIoCixGR OLNW6wEonHxnaNjpK36WFWNH/6tXbxKMuWBDM9R3xtDtWoaLDHnMOQNCSsGVMqOI 9uMi39yy5eMdBL5EINcaVkZvXFD54A== =ul7F -----END PGP SIGNATURE-----