Re: [PATCH treewide 4/5] iio: frequency: adf4377: Make sure clk_init_data is fully initialized
Jonathan Cameron <[email protected]>
| Newsgroups | org.kernel.vger.linux-omap,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-clk,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-spi |
|---|---|
| Message-ID | <20260820023804.70ba61d1@jic23-huawei> |
On Wed, 19 Aug 2026 17:22:41 -0400 Brian Masney <[email protected]> wrote: > On Wed, Aug 19, 2026 at 09:05:18PM +0200, Geert Uytterhoeven wrote: > > The clk_init_data structure contains several mutually-exclusive members > > for different methods to specify the possible parents of a clock, > > prompting drivers to initialize only the members they need. However, > > not initializing all members may cause subtle issues, which are only > > exposed when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is > > enabled. > > > > adf4377_clk_register() fills in init.parent_data, and assumes that > > init.parent_names is NULL. However, the latter in uninitialized, and > > thus may cause a crash. > > > > Make sure all members are fully initialized, to fix such bugs, and to > > avoid future breakage when converting drivers to a different method for > > specifying the parents. > > > > Fixes: 60e5448ddbec2dc2 ("iio: frequency: adf4377: add clk provider support") > > Signed-off-by: Geert Uytterhoeven <[email protected]> > > Reviewed-by: Brian Masney <[email protected]> > Applied to the fixes-togreg branch of iio.git I'll rebase on rc1 before sending a pull request (so waiting for that to be available) Thanks, Jonathan