RE: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully initialized

> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: Thursday, August 20, 2026 4:05 AM
> To: Tero Kristo <[email protected]>; Stephen Boyd <[email protected]>; Brian
> Masney <[email protected]>; Jerome Brunet
> <[email protected]>; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○Ｃ
> ＰＴ) <[email protected]>; Nuno Sa
> <[email protected]>; Guenter Roeck <[email protected]>; Michael
> Hennerich <[email protected]>; Antoniu Miclaus
> <[email protected]>; Jonathan Cameron <[email protected]>;
> David Lechner <[email protected]>; Andy Shevchenko
> <[email protected]>; Sunny Luo <[email protected]>; Xianwei Zhao
> <[email protected]>; Mark Brown <[email protected]>; Kees
> Cook <[email protected]>; Kevin Hilman <[email protected]>; Mathieu
> Dubois-Briand <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Geert Uytterhoeven
> <[email protected]>
> Subject: [PATCH treewide 2/5] clk: visconti: Make sure clk_init_data is fully
> initialized
> 
> The clk_init_data structure contains several mutually-exclusive members for
> different methods to specify the possible parents of a clock, prompting drivers
> to initialize only the members they need.  However, not initializing all members
> may cause subtle issues, which are only exposed when
> CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is
> enabled.
> 
> visconti_clk_register_gate() fills in init.parent_data, and assumes that
> init.parent_names is NULL.  However, the latter in uninitialized, and thus may
> cause a crash.
> 
> Make sure all members are fully initialized, to fix such bugs, and to avoid future
> breakage when converting drivers to a different method for specifying the
> parents.
> 
> Fixes: b4cbe606dc3674b2 ("clk: visconti: Add support common clock driver
> and reset driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Nobuhiro Iwamatsu <[email protected]>

Best regards,
  Nobuhiro