Re: [PATCH v5 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO
Stafford Horne <[email protected]>
| Newsgroups | org.kernel.vger.linux-openrisc,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <aWe6wsho70kEXirE@antec> |
On Wed, Jan 14, 2026 at 04:36:23PM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > Thanks for your patch! > > On Wed, 14 Jan 2026 at 16:14, Stafford Horne <[email protected]> wrote: > > In commit f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible > > string for opencores,gpio") we marked opencores,gpio to be allowed with > > brcm,bcm6345-gpio. This was wrong, opencores,gpio is not hardware > > equivalent to brcm,bcm6345-gpio. It has a different register map and > > is 8-bit vs braodcom which is 32-bit. Change opencores,gpio to be a > > broadcom or Broadcom Right, thanks for spotting this. > > separate compatible string for MMIO GPIO. > > > > Fixes: f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string for opencores,gpio") > > Signed-off-by: Stafford Horne <[email protected]> > > --- > > Since v4: > > - New patch. > > - Rebased old patch and rewrote commit message. > > The actual patch LGTM, so > Reviewed-by: Geert Uytterhoeven <[email protected]> Thanks. -Stafford